Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove LintRule::docs() #1381

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Dec 30, 2024

This commit removes LintRule::docs() method and consequently all .md files
with documentation for the lint rules.

These docs now live at https://github.com/denoland/docs/tree/main/lint/rules.

Some code from dlint binary that prints these docs have been removed too
and instead points to relevant https://docs.deno.com/lint/rules/ pages.

This will allow to save about ~400Kb from the deno binary size.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bartlomieju bartlomieju merged commit ee5b589 into denoland:main Dec 31, 2024
6 checks passed
@bartlomieju bartlomieju deleted the remove_docs branch December 31, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants