Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsx-curly-braces): ignore values that require escaping #1420

Merged
merged 4 commits into from
Feb 21, 2025
Merged

fix(jsx-curly-braces): ignore values that require escaping #1420

merged 4 commits into from
Feb 21, 2025

Conversation

marvinhagemeister
Copy link
Contributor

@marvinhagemeister marvinhagemeister commented Feb 21, 2025 •
edited
Loading

Don't turn expression into a string when the JSX child would require escaping or it would clash with jsx-no-unescaped-entities rule.

Fixes denoland/deno#28225

dsherret
dsherret approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit 85e100a into main Feb 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno lint - jsx-curly-braces rule causes syntax error on --fix
2 participants
@marvinhagemeister @dsherret