Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback to notion #1403

Merged
merged 7 commits into from
Feb 7, 2025
Merged

Feedback to notion #1403

merged 7 commits into from
Feb 7, 2025

Conversation

philhawksworth
Copy link
Member

  • Updates feedback middleware to send the feedback to Notion rather than Google sheets

import type { FeedbackSubmission } from "../../types.ts";

// Collecting entries to this internal Notion page:
// https://www.notion.so/denolandinc/192771466362800da55dc4552ad9a70c?v=192771466362803793d5000c0f522280
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to publicise this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's private so I thought there was no harm and it was convenient... but I'm happy to remove it if that's our preference

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think probably better not shared just to discourage eyes from trying to look at it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it

@philhawksworth
Copy link
Member Author

Test submissions work as expected

Copy link
Collaborator

@thisisjofrank thisisjofrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woop!

@philhawksworth philhawksworth merged commit 11a7014 into main Feb 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants