Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1398
Or, at least it attempts to. Not entirely sure what the desired functionality is here. I'd appreciate guidance on some sensible tests and clarification around how we intend this to be used. I improved my test case from the comment I posted last night on the issue. You can see it here. I support two forms of worker import rewriting right now.
new URL("../workers/myFirstWorker.ts", import.meta.url),
useWorker("../../workers/doStuff.ts");
This is still a bit hacky, since I had to declare a global state in order to share the current request url with the esbuild plugin. You can see that in
bundleAssetRoute
where I do this:I then use it later like:
Otherwise I don't know how to rewrite the
new URL(.....)
anduseWorker(....)
calls to point to the correct value in the server, since we append that randomNonce to our URLs. Maybe I'm misunderstanding something.As always looking into a new section of code was very illuminating, although I think I need a bit of help here in order to get this over the line.