-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
www: add language switcher to code blocks #1623
Draft
marvinhagemeister
wants to merge
11
commits into
main
Choose a base branch
from
code-blocks-fancy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfdca5e
to
b35d9b9
Compare
Would be cool if there was a copy button, giving that we're rolling our own codeblocks anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR spices up the code blocks quite a bit. It adds a language selector so that you can switch between
TypeScript/JavaScript
code. The setting is persisted in local store and is applied globally to all code blocks.On top of that the PR adds the ability to add a title to a code block so that it tells the user what they're looking at. In most cases that will be the file name.
The marked smartypants plugin doesn't work with the latest marked version. The previous plugin would parse the final generated HTML again anyway instead of just tapping into marked's parser. So I've hand rolled our own smartypants.
fresh-code-blocks.mp4