Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

www: docs: fix: Header nav items shouldn't wrap on mobile #2821

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

www: docs: fix: Header nav items shouldn't wrap on mobile #2821

wants to merge 14 commits into from
+54 −36

Conversation

davis9001
Copy link
Contributor

@davis9001 davis9001 commented Feb 5, 2025 •
edited
Loading

Following up on #2820

I noticed the addition of the extra icon in the nav bar made the nav items in the Header newline wrap on small screens (mobile smaller than sm).
image

This pull request fixes that by doing the following:

  • On mobile: Hides GitHub social icon in Header

Some other changes I snuck in:

  • Reintroduced semi-transparent backgorund on header
  • Adjustments to spacing/alignment on Header items
  • Refactor ThemeToggle Island to be less Deno Fresh specific (more reusable)
  • Refactor social icons into SocialIcons component (removed duplication)
  • Added Discord social icon to Footer on all screen sizes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davis9001 @marvinhagemeister