feat(ini): reviver value is type casted #6887
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6887 +/- ##
=======================================
Coverage 94.11% 94.11%
=======================================
Files 581 581
Lines 42707 42708 +1
Branches 6796 6797 +1
=======================================
+ Hits 40194 40196 +2
+ Misses 2463 2462 -1
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timreichen
reviewed
Nov 29, 2025
ini/parse.ts
Outdated
| } | ||
|
|
||
| const QUOTED_VALUE_REGEXP = /^"(?<value>.*)"$/; | ||
| function defaultReviver(_key: string, value: string, _section?: string) { |
Contributor
There was a problem hiding this comment.
Suggested change
| function parseValue(_key: string, value: string) { |
ini/parse.ts
Outdated
| } | ||
|
|
||
| const val = reviver(key, value, sectionName); | ||
| const parsedValue = defaultReviver(key, value, sectionName); |
Contributor
There was a problem hiding this comment.
Suggested change
| const parsedValue = defaultReviver(key, value, sectionName); | |
| let parsedValue = parseValue(key, value); |
ini/parse.ts
Outdated
Comment on lines
201
to
203
| const val = options.reviver | ||
| ? options.reviver(key, parsedValue, sectionName) | ||
| : parsedValue; |
Contributor
There was a problem hiding this comment.
Suggested change
| const val = options.reviver | |
| ? options.reviver(key, parsedValue, sectionName) | |
| : parsedValue; | |
| if (options.reviver) parsedValue = options.reviver(key, parsedValue, sectionName); |
kt3k
reviewed
Dec 1, 2025
ini/parse_test.ts
Outdated
Comment on lines
261
to
263
| const json = '{ "a": 100, "b": true, "c": null, "d": "foo" }'; | ||
| const parsedJson = JSON.parse(json, (_key, value) => value); | ||
| assertEquals(parsedJson, expected); |
Member
There was a problem hiding this comment.
I don't think we need to run JSON version here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6884