-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dprint fixer #4024
Add dprint fixer #4024
Conversation
c208aa3
to
728bc6c
Compare
@hsanson sorry for noise in this PR (I had to get docker installed locally so I could run the tests). It's now ready to go. The problem I couldn't figure out was that, of course, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for the work. Would be great if you can add also help documentation to the PR:
- Add
ale-dprint-options
section intoale.txt
explaining the possible configuration variables. - Add
ale-javascript-dprint
section toale-javascript.txt
which points toale-dprint-options
. See ale-javascript-deno and ale-javascript-cspell for example. - Repeat for every language supported by dprint (e.g. typescript, json, and markdown).
7cdaef3
to
7f99416
Compare
Thank you for your help getting this PR into shape. I've added all the languages which Also related: dprint/plugins#6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extensive documentation. Just one small detail and this should be ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good contribution and well documented.
This is attempt number 3. See https://github.com/dense-analysis/ale/pulls?q=is%3Apr+is%3Aclosed+dprint
I have changed to use
stdin
. This is working well for me so far 💪