Fixed the issue with Black ignoring config file to tell it which file is being processed. (#3406) #4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…analysis#3406) Add test for stdin-filename on test/fixers/test_ruff_format_fixer_callback.vader
hsanson
requested changes
Feb 7, 2025
| @@ -53,7 +60,7 @@ Execute(Pipenv is detected when python_black_auto_pipenv is set): | |||
| call ale#test#SetFilename('../test-files/python/pipenv/whatever.py') | |||
|
|
|||
| AssertEqual | |||
| \ {'command': ale#Escape('pipenv') . ' run black -'}, | |||
| \ {'command': ale#Escape('pipenv') . ' run black --stdin-filename ''/testplugin/test/test-files/python/pipenv/whatever.py'' -'}, | |||
There was a problem hiding this comment.
These paths need to also be escaped. Linter is failing on Windows because of this:
(5/7) [EXECUTE] Pipenv is detected when python_black_auto_pipenv is set
(5/7) [EXECUTE] (X) {'command': 'pipenv run black --stdin-filename C:\testplugin\test\test-files\python\pipenv\whatever.py -'} should be equal to {'command': 'pipenv run black --stdin-filename ''/testplugin/test/test-files/python/pipenv/whatever.py'' -'}
(6/7) [EXECUTE] Poetry is detected when python_black_auto_poetry is set
(6/7) [EXECUTE] (X) {'command': 'poetry run black --stdin-filename C:\testplugin\test\test-files\python\poetry\whatever.py -'} should be equal to {'command': 'poetry run black --stdin-filename ''/testplugin/test/test-files/python/poetry/whatever.py'' -'}
(7/7) [EXECUTE] uv is detected when python_black_auto_uv is set
(7/7) [EXECUTE] (X) {'command': 'uv run black --stdin-filename C:\testplugin\test\test-files\python\uv\whatever.py -'} should be equal to {'command': 'uv run black --stdin-filename ''/testplugin/test/test-files/python/uv/
There was a problem hiding this comment.
Hi,
Thanks for your help, I fixed the problem.
…analysis#3406) Fixed the problem on Windows's tests.
|
Linter error here: |
… is being processed. Trailing whitespace removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue with Black ignoring config file to tell it which file is being processed. (#3406)
Add test for stdin-filename