Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict typing for the elm update checker #11716

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

markhallen
Copy link
Contributor

@markhallen markhallen commented Mar 3, 2025

What are you trying to accomplish?

As part of our ongoing effort to improve our sorbet typing we are adding strict typing to the elm update_checker files.

How will you know you've accomplished your goal?

The specs should pass without any regressions.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@markhallen markhallen requested a review from a team as a code owner March 3, 2025 16:07
@github-actions github-actions bot added the L: elm Elm packages label Mar 3, 2025
abdulapopoola
abdulapopoola previously approved these changes Mar 3, 2025
@markhallen markhallen force-pushed the markhallen/strictly-type-elm-cli-parser branch from 4d77f9d to 0066579 Compare March 3, 2025 16:12
@markhallen markhallen force-pushed the markhallen/strictly-type-elm-cli-parser branch from 0066579 to 78a9af9 Compare March 3, 2025 16:13
@markhallen markhallen force-pushed the markhallen/strictly-type-elm-cli-parser branch from 78a9af9 to 9db1bbc Compare March 3, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: elm Elm packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants