Bump version in maven security advisory#228
Merged
Conversation
kbukum1
approved these changes
Sep 17, 2024
Contributor
kbukum1
left a comment
kbukum1
left a comment
There was a problem hiding this comment.
According to the description (reason), it is make sense to make this change on the smoke tests. Please don't forget to take back the branch name in the smoke.yml before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue: #226
I've made a change to the order of maven versions in this PR: dependabot/dependabot-core#10558 . Based on that change, which is based on the maven spec, version 1.5.11 == 1.5.11.RELEASE . Before this change, this test passed because it erroneously concluded that 1.5.11.RELEASE < 1.5.11.