Revert "Revert "Bump version in maven security advisory""#232
Merged
Conversation
amazimbe
force-pushed
the
revert-229-revert-228-amazimbe/use-new-maven-version
branch
from
205ce7f to
30da231
Compare
jakecoffman
reviewed
Oct 2, 2024
amazimbe
force-pushed
the
revert-229-revert-228-amazimbe/use-new-maven-version
branch
from
30da231 to
d0ff655
Compare
jakecoffman
approved these changes
Oct 2, 2024
kbukum1
approved these changes
Oct 2, 2024
amazimbe
deleted the
revert-229-revert-228-amazimbe/use-new-maven-version
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #229
Link to issue: #226
I've made a change to how maven orders versions in this PR: dependabot/dependabot-core#10558 . As a result, version 1.5.11 == 1.5.11.RELEASE . Before this change, this test passed because it erroneously concluded that 1.5.11.RELEASE < 1.5.11.