chore(*): 패키지 버전 설정 및, 파일 정리 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrevile
requested review from
Doeunnkimm,
semnil5202 and
LeeJeongHooo
as code owners
sambad-adventure
changed the title
Doeunnkimm
reviewed
Jun 20, 2024
semnil5202
approved these changes
Jun 20, 2024
| @@ -1,4 +1,4 @@ | |||
| This is a [Next.js](https://nextjs.org) project bootstrapped with [`create-next-app`](https://nextjs.org/docs/app/api-reference/create-next-app). | |||
| This is a [Next.js](https://nextjs.org/) project bootstrapped with [`create-next-app`](https://github.com/vercel/next.js/tree/canary/packages/create-next-app). | |||
There was a problem hiding this comment.
혹시 요런 수정사항은 pnpm install 하면서 생긴건가여?? 아니면 직접 수정하신건가요?? 궁금해서 질문드립니다.
| :root { | ||
| --background: #ffffff; | ||
| --foreground: #171717; | ||
| --max-width: 1100px; |
There was a problem hiding this comment.
모바일 가로 화면 잡으실 때 body max-width는 PC 사이즈로 두시고, 따로 Root Layout Component를 통해서 잡으시나여?
혹시 1100px은 어떤 기준인가요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
apps 디렉토리 하위의 서비스 디렉토리의 next 버전과 react 버전을 픽스했습니다.
🔗 링크
https://www.notion.so/apps-fc27c354573d40d4b42b78873fb1dc1f?pvs=4
🙏 여기는 꼭 봐주세요!