Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkhj0423
requested review from
derrickkim0109 and
mooyoung2309
and removed request for
derrickkim0109
mooyoung2309
approved these changes
Jun 28, 2023
Comment on lines
+35
to
+38
| private func navigationLeadingArea(action: @escaping () -> Void) -> some ToolbarContent { | ||
| ToolbarItem(placement: .navigationBarLeading) { | ||
| Button { | ||
| action() |
…e), Token ExpireTime locale 서버에서 미적용된 문제 해결중
|
@mooyoung2309 @derrickkim0109
궁금하신 부분은 코멘트 남겨주세요 |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 요약
크루 참여, 크루 생성에 필요한 UI와 나오지 않은 서버스펙에 대비하여 로직을 작성해놨습니다.
기존에 문제되었던 상단의 SafeArea가 스크롤 시에 짤려보이는 부분을 해결했습니다.
크루 랭킹 부분은 Profile 부분이 SharedDesignSystem에 작성된 이슈가있어서 따로 수정하지 않았습니다.
📌 변경 사항
✅ PR check list
Linked Issue
close #98