[Feat/#113] CrewJoin API 개발 완료 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooyoung2309
approved these changes
Jul 5, 2023
Comment on lines
+22
to
+28
| public static func joinCrew(_ code: String) -> Endpoint<CrewResponseDTO> { | ||
| let accessToken = KeyChainStore.shared.load(property: .accessToken) | ||
|
|
||
| return Endpoint(path: "crews/join/\(code)", | ||
| httpMethod: .post, | ||
| headers: ["Authorization" : "Bearer \(accessToken)"]) | ||
| } |
There was a problem hiding this comment.
p5;
매 요청마다 auth가 필요하다면, accessToken을 Endpoint 내부에서 처리하는 방식은 어떤가요 ?
There was a problem hiding this comment.
NetworkProvider 쪽에 아예 박아버리려다가 accessToken 없이 헤더를 넣어야하는 케이스도 혹시 생길까봐 유동적으로 넣을 수 있도록 넣어놨어
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 요약
CrewMake로 만든 크루의 Code를 통해 다른 크루에 참여하는 CrewJoin API를 개발하였습니다.
하지만 아직 서버쪽에서 내가만든 크루에 내가 코드를 통해 참여하게될 경우의 엣지케이스를 처리하지않아 2차수정이 필요합니다.
📌 변경 사항
✅ PR check list
Linked Issue
close #113