fix: Avatar에서 에러와 긴 이미지 대응 #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doeunnkimm
requested review from
newminkyung,
hjy0951 and
deepbig
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Doeunnkimm
commented
Apr 29, 2024
Comment on lines
+27
to
+30
| // eslint-disable-next-line @next/next/no-img-element | ||
| <img src={profileImage} width={size} height={size} alt="profile_image" onError={handleAddDefaultImg} /> | ||
| )} | ||
| </div> |
There was a problem hiding this comment.
흠 next/image를 사용하면 onError 하나 때문에 state로 말아서 넣어줘야 해서.. img를 택했는데 다들 의견이 궁금해유~
There was a problem hiding this comment.
이미지로 해도 좋을듯! 어처피 아바타에 들어가는거니까 괜춘치 않읆까~?
newminkyung
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
🎉 어떻게 해결했나요?
Avatar적용📚 Attachment (Option)