fix: finishRun stack overflow (#191)

dequelabs · Sep 27, 2021 · 41b817e · 41b817e
1 parent 566897a
commit 41b817e
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/main/java/com/deque/html/axecore/selenium/AxeBuilder.java b/src/main/java/com/deque/html/axecore/selenium/AxeBuilder.java
@@ -94,7 +94,7 @@ public class AxeBuilder {
     "var context = typeof arguments[0] === 'string' ? JSON.parse(arguments[0]) : arguments[0];" +
     "context = context || document;" +
     "var options = JSON.parse(arguments[1]);" +
-    "axe.run(context, options).then(callback)";
+    "axe.run(context, options).then(res => JSON.parse(JSON.stringify(res))).then(callback)";
 
   public final String unsafeAllOrigins = "<unsafe_all_origins>";
   public final String sameOrign = "<same_origin>";
@@ -129,8 +129,9 @@ public class AxeBuilder {
     "const context = typeof arguments[0] == 'string' ? JSON.parse(arguments[0]) : arguments[0];" +
     "const options = JSON.parse(arguments[1]);" +
     "const cb = arguments[arguments.length - 1];" +
-    "window.c = context; window.o = options;" + // FIXME
-    "window.axe.runPartial(context, options).then(cb);";
+    // JSON passthrough removes propereties that are set to undefined. Fixes an infinite loop in
+    // finishRun
+    "window.axe.runPartial(context, options).then(res => JSON.parse(JSON.stringify(res))).then(cb);";
 
   private static String frameContextScript = 
     "const context = typeof arguments[0] == 'string' ? JSON.parse(arguments[0]) : arguments[0];" +