fix(selenium): add backwards compatible way of settings various timeouts when using selenium 3 #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uts when using selenium 3
Zidious
commented
Sep 26, 2024
Comment on lines
+209
to
+216
| <!-- https://mvnrepository.com/artifact/org.mockito/mockito-core --> | ||
| <dependency> | ||
| <groupId>org.mockito</groupId> | ||
| <artifactId>mockito-core</artifactId> | ||
| <!-- versions >4 require Java 11 --> | ||
| <version>4.11.0</version> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Mostly formatting changes - this test dependency is the new addition.
michael-siek
approved these changes
Sep 26, 2024
stephenmathieson
approved these changes
Sep 26, 2024
I believe this has been in discussion for the 5 release. As updating to the the later versions of Selenium 4 does require Java 11. So we'd need to think carefully whether we want to continue to support selenium 4.X on Java 8 or move to selenium >4 on Java 11 or both |
|
Is there an issue for tracking removing Selenium 3 support? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds adds a selenium 3 compatible fallback when we attempt to set the various timeouts.
QA Notes: Using Selenium 3 it should analyze correctly there should also be no change to the existing behaviour when using selenium 4.
Closes: #479