Skip to content

fix: inject correct skill path into agent context for sandbox and loc…#145

Merged
yhjun1026 merged 1 commit intoderisk-ai:mainfrom
niiish32x:fix/nsh_skill_path_fix_20260306
Mar 6, 2026
Merged

fix: inject correct skill path into agent context for sandbox and loc…#145
yhjun1026 merged 1 commit intoderisk-ai:mainfrom
niiish32x:fix/nsh_skill_path_fix_20260306

Conversation

@niiish32x
Copy link
Contributor

…al modes

  • Persist skill path (project_skill_dir/) to DB on create/update when path is not explicitly provided, so legacy records without path are self-healing after next save
  • Fix var_skills in ReActMasterAgent to resolve skill paths correctly: use sandbox client's skill_dir when the skill directory exists in the sandbox, otherwise fall back to the local DATA_DIR/skill directory
  • Add derisk-ob.toml configuration

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

…al modes

- Persist skill path (project_skill_dir/<uuid>) to DB on create/update
  when path is not explicitly provided, so legacy records without path
  are self-healing after next save
- Fix var_skills in ReActMasterAgent to resolve skill paths correctly:
  use sandbox client's skill_dir when the skill directory exists in the
  sandbox, otherwise fall back to the local DATA_DIR/skill directory
- Add derisk-ob.toml configuration
@github-actions github-actions bot added the fix label Mar 6, 2026
Copy link
Collaborator

@yhjun1026 yhjun1026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhjun1026 yhjun1026 merged commit 83a1400 into derisk-ai:main Mar 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants