-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Vue 3 #699
Draft
lukaslihotzki
wants to merge
7
commits into
desec-io:main
Choose a base branch
from
lukaslihotzki:vue3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Upgrade to Vue 3 #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice work 👍 |
Merged
@lukaslihotzki Thanks for the work! Are you still in for moving it on? :) |
@Rotzbua @lukaslihotzki Hey... long time no chat! Are you interested in finishing this migration? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #649
There are still some issues with the upgrade to Vue 3 that are not solved in this draft. Some of them can be solved independently of the upgrade:
a href
links instead ofrouter-link
for those.$each
.npx depcheck
returns many other unused dependencies. Can they be removed safely?The other issues need to be fixed in this draft:
I don't exactly understand how vue-demi should be used. If there are problems, use
npx vue-demi-switch 2
ornpx vue-demi-switch 3
depending on the version you currently want to use. Clearing node_modules can also help.I
.eslintignore
everything, becausenpm run serve
refuses to run otherwise. This should be removed if needed.The commit chore(webapp): update to vue 3 was made by changing
.eslintrc.js
and running this in www/webapp: