Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Vue 3 #699

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Upgrade to Vue 3 #699

wants to merge 7 commits into from

Conversation

lukaslihotzki
Copy link
Contributor

@lukaslihotzki lukaslihotzki commented Mar 11, 2023

Refs #649

There are still some issues with the upgrade to Vue 3 that are not solved in this draft. Some of them can be solved independently of the upgrade:

  • vue-router 4 (part of Vue 3) does not support routes to other origins. We should probably use simple a href links instead of router-link for those.
  • Vuelidate 2 (new version compatible with Vue 2 and Vue 3) adds nested validators that should be used instead of the now unsupported $each.
  • npx depcheck returns many other unused dependencies. Can they be removed safely?

The other issues need to be fixed in this draft:

  • The new copy to clipboard implementation is untested.
  • The style is broken, probably because there are a lot of eslint errors that cannot be fixed automatically.

I don't exactly understand how vue-demi should be used. If there are problems, use npx vue-demi-switch 2 or npx vue-demi-switch 3 depending on the version you currently want to use. Clearing node_modules can also help.

I .eslintignore everything, because npm run serve refuses to run otherwise. This should be removed if needed.

The commit chore(webapp): update to vue 3 was made by changing .eslintrc.js and running this in www/webapp:

npm remove --save vue-template-compiler vuetify-loader vue-cli-plugin-vuetify
npm install --save vue@3 vuetify@3 vue-router@4 webpack-plugin-vuetify @vue/compiler-sfc
npm install --save-dev vue-demi eslint-plugin-vuetify
npx vue-demi-switch 3
./node_modules/.bin/eslint --fix 'src/**'

@Rotzbua
Copy link
Contributor

Rotzbua commented Mar 12, 2023

Nice work 👍
I would recommend to migrate Vuelidate in a separate PR before upgrading vue.

@peterthomassen peterthomassen mentioned this pull request Jun 15, 2023
@peterthomassen
Copy link
Member

@lukaslihotzki Thanks for the work! Are you still in for moving it on? :)

@peterthomassen
Copy link
Member

@Rotzbua @lukaslihotzki Hey... long time no chat! Are you interested in finishing this migration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants