Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#837 Devcontainer cli add label #846

Merged
merged 7 commits into from
Jun 21, 2024
Merged

#837 Devcontainer cli add label #846

merged 7 commits into from
Jun 21, 2024

Conversation

prathameshzarkar9
Copy link
Contributor

Issue #832
Adding labels to containers build by devcontainer cli

@prathameshzarkar9 prathameshzarkar9 requested a review from a team as a code owner June 14, 2024 11:34
@prathameshzarkar9 prathameshzarkar9 mentioned this pull request Jun 14, 2024
Closed
This was linked to issues Jun 14, 2024
Adding labels to containers build by devcontainer cli #837
Closed
--label option for devcontainer build #157
Closed
@samruddhikhandale samruddhikhandale mentioned this pull request Jun 14, 2024
Closed
samruddhikhandale
samruddhikhandale requested changes Jun 14, 2024
View reviewed changes
@prathameshzarkar9
Copy link
Contributor Author

prathameshzarkar9 commented Jun 16, 2024 •
edited
Loading

hi @samruddhikhandale ,
All the test cases are now succeed. Kindly review the PR once.

chrmarti
chrmarti requested changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, left a few comments.

chrmarti
chrmarti approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

samruddhikhandale
samruddhikhandale approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks!

@samruddhikhandale samruddhikhandale merged commit 740a686 into devcontainers:main Jun 21, 2024
19 checks passed
@Roemer Roemer mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrmarti chrmarti chrmarti approved these changes

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding labels to containers build by devcontainer cli --label option for devcontainer build
3 participants
@prathameshzarkar9 @chrmarti @samruddhikhandale