Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proposal for features contributing lifecycle scripts #196

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Add proposal for features contributing lifecycle scripts #196

merged 4 commits into from
Feb 13, 2023

Conversation

joshspicer
Copy link
Member

ref: #60, #181

@joshspicer joshspicer requested a review from a team as a code owner January 30, 2023 22:08
chrmarti
chrmarti requested changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Left a few comments.

@eitsupi eitsupi mentioned this pull request Jan 31, 2023
Closed
samruddhikhandale
samruddhikhandale reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides Christof's comment, everything else looks good to me.

@joshspicer joshspicer mentioned this pull request Jan 31, 2023
Merged
Cindys82
Cindys82 reviewed Feb 2, 2023
View reviewed changes
Copy link

@Cindys82 Cindys82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone please give me some advice for what I need to be do to get this app to work for me please and thanks

@bamurtaugh
Copy link
Member

Hi @Cindys82, could you let us know what you're trying to get working (i.e. which app), and if you have any specific issues you can share? Thanks so much!

chrmarti
chrmarti previously requested changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on naming. LGTM otherwise.

@joshspicer joshspicer requested a review from chrmarti February 7, 2023 18:22
alexdima
alexdima approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexdima alexdima dismissed chrmarti’s stale review February 13, 2023 20:28

The comment has been addressed.

@joshspicer joshspicer merged commit bdd615e into main Feb 13, 2023
@joshspicer joshspicer deleted the joshspicer/features-contribute-lifecycle-scripts branch February 13, 2023 21:13
@samruddhikhandale samruddhikhandale mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markphip markphip markphip left review comments

@bamurtaugh bamurtaugh bamurtaugh left review comments

@Cindys82 Cindys82 Cindys82 left review comments

@alexdima alexdima alexdima approved these changes

@samruddhikhandale samruddhikhandale Awaiting requested review from samruddhikhandale

@chrmarti chrmarti Awaiting requested review from chrmarti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joshspicer @bamurtaugh @markphip @alexdima @chrmarti @samruddhikhandale @Cindys82