Conversation
gadomski
reviewed
Apr 17, 2026
Comment on lines
+9
to
+12
| pub trait ToDataFusionSQL { | ||
| /// Convert Expression to SQL for DataFusion and geodatafusion. | ||
| fn to_datafusion_sql(&self) -> Result<String, Error>; | ||
| } |
Collaborator
There was a problem hiding this comment.
If there's only one implementation, do we need the trait? Can we just implement directly on Expr?
| unused_results | ||
| )] | ||
| #![allow(clippy::result_large_err)] | ||
| #![cfg_attr(test, allow(unused_crate_dependencies))] |
Collaborator
There was a problem hiding this comment.
I generally prefer to do a
#[cfg(test)]
use foo as _;
gadomski
requested changes
Apr 17, 2026
Collaborator
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
Just a couple of nits/tweaks on impelmentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for generating geodatafusion compatible SQL.
Adds a test helper to convert the test ndjson file to geoparquet to use for ducdkb / datafusion integration tests.