Add options to format identifiers (functions, properties)#92
Draft
Add options to format identifiers (functions, properties)#92
Conversation
Contributor
Author
|
@gadomski putting this up more of a prototype to figure out the right API that we want to use for this. |
gadomski
reviewed
Oct 31, 2025
Collaborator
gadomski
left a comment
There was a problem hiding this comment.
Makes sense to me as a low-level, but we'll want some sort of "resolver generator" for the most common patterns?
let options = DuckDbOptionsBuilder::new().struct_field("assets").build();
expr.to_ducksql_with_options(options);The resolver would then do whatever transformations necessary to turn properties that start with assets into the appropriately-quoted dot notation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype to allow passing in a json whitelist or a function taking an input identifier string and returning the appropriate SQL.