Skip to content

Conversation

@pantierra
Copy link
Contributor

  • Add CloudEvents sink deployment for eoapi-notifier integration
  • Configure dynamic secret name for PostgreSQL connection
  • Add local development configuration with reduced resources
  • Support both CI and local test environments

@pantierra pantierra marked this pull request as draft October 24, 2025 10:09
@pantierra pantierra changed the title Add Knative integration for notifications feat: Add Knative integration for notifications Oct 24, 2025
@pantierra pantierra force-pushed the feature/ci-knative branch 4 times, most recently from bdecd00 to 695abb7 Compare October 24, 2025 10:58
@pantierra pantierra marked this pull request as ready for review October 24, 2025 11:13
@pantierra pantierra requested a review from ciaransweet October 24, 2025 11:20
@pantierra pantierra self-assigned this Oct 24, 2025
- Add CloudEvents sink deployment for eoapi-notifier integration
- Configure dynamic secret name for PostgreSQL connection
- Add local development configuration with reduced resources
- Support both CI and local test environments
Copy link
Contributor

@ciaransweet ciaransweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just general question on knative version

run: |
echo "=== Installing Knative Serving ==="
# Install Knative Serving CRDs
kubectl apply -f https://github.com/knative/serving/releases/download/knative-v1.17.0/serving-crds.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we maybe want to parameterise the knative version?

fi

log_info "Installing Knative Serving..."
kubectl apply -f https://github.com/knative/serving/releases/download/knative-v1.17.0/serving-crds.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto the parameterising

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants