refactor: migrate from XState to Zustand for state management #1042
+1,425
−488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace XState machine with Zustand store for simpler state management - Migrate feature highlighting functionality to Zustand - Migrate bounding box selection workflow to Zustand - Remove XState dependencies and xstate directory - All existing tests pass, including E2E bbox interaction test
- Add comprehensive test organization with shared utilities - Create test_utils.py with common helper functions and constants - Consolidate validation functions and interaction patterns - Add bbox selection workflow tests with proper state validation - Add feature highlighting stability tests - Improve test maintainability with self-explaining code - Organize tests by functionality (bbox vs feature highlighting) - Add shared fixtures in conftest.py for test reuse - Remove duplicate code patterns across test files - All 10 tests passing with improved coverage
…ration - Remove verbose comments and improve import organization in index.tsx - Clean up formatting in store.ts and toolbar.tsx for better readability - Add ClassVar type annotations to test constants for type safety - Improve code formatting and consistency in test files - Remove unused variables in test files for better maintainability
kylebarron
reviewed
Nov 7, 2025
Member
kylebarron
left a comment
kylebarron
left a comment
There was a problem hiding this comment.
Thanks for the PR!
We currently have two different places for state management:
- backbone models (via jupyter widgets) for any state coming in from Python
- xstate -> zustand for any "within JS application/UI state"
Do you think this split makes sense? Should we try to unify all state in a single place?
- Move state files to dedicated src/state/ directory for better organization - Clean up and standardize JSDoc comments across state management files - Add clear separation between client-side (Zustand) and Python-synced state - Improve inline comments in index.tsx for better code readability - Remove redundant documentation, rely on concise code comments
Member
Author
|
@kylebarron thanks for the review. I think we should keep them separate. The parts handled by Zustand don’t need to be exposed, this avoids unnecessary back-and-forth serialization for UI-only state. I added some changes to better document this approach. This is ready for another review. |
Member
Author
|
@kylebarron I added more test coverage to include the tooltip on feature hover. I won't be adding more changes to this until your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #916