Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ranges_for_request,get,set. And then a genericSyncCacheStoreandAsyncCacheStorecould use a generic cache, while not tying the cache implementation to the name of the wrapper. (I.e. we currently have aBlockCacheclass, where the cache implementation is tied to the specific wrapper)readmethod. Instead the block cache should just implement and expose publicly the sameget_range&get_rangesorget_range_async&get_ranges_asyncas the underlying backend. Then we can have a genericReadwrapper that takes an arbitrary backend that supportsget_rangeandget_rangesand implements file methods on them.