query-params-datetime-range #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it makes sense. could you add a test case for this? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage ? 81.89%
=======================================
Files ? 13
Lines ? 856
Branches ? 103
=======================================
Hits ? 701
Misses ? 103
Partials ? 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi Vincent, thanks for the review! I've added an assert for the value of the datetime key of the search_query to an existing test. Is this sufficient or should I make a separate test? If so could you give me some pointers as to how to best implement it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the datetime query param ranges from 00:00:00 on the selected day to 00:00:00 on the next. This can cause Items with datetime or datetime_start set to 00:00:00 on the next day to be included in queries for the day before.
This pull request proposes to subtract 1ms from the end datetime to set it to 23:59:59 on the same day to prevent inclusion of unwanted data.