-
Notifications
You must be signed in to change notification settings - Fork 28
Use plain language #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use plain language #138
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -3,16 +3,14 @@ title: What is a devfile | |||||
description: What is a devfile | ||||||
--- | ||||||
|
||||||
You can use devfiles to automate and simplify your development process | ||||||
by adopting the existing devfiles that are available in the [public community registry](https://registry.devfile.io/viewer) | ||||||
or by authoring your own devfiles to record custom instructions to | ||||||
configure and run your build environment as a YAML-formatted text file. | ||||||
You can make these devfiles available in the supporting build tools and | ||||||
IDEs that can automatically process the devfile instructions to configure | ||||||
and build a running application from a development project. | ||||||
|
||||||
Using the recommended best practices from the devfile, the tools and IDE | ||||||
can: | ||||||
`devfile.yaml` describes how to configure and run build environment for | ||||||
your project in a development container. You can create devfile from scratch or | ||||||
adopt existing from [public community registry](https://registry.devfile.io/viewer). | ||||||
|
||||||
Certain build tools and IDEs can automatically process the devfile | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As I understand it, the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
@abitrolly I corrected to developer tool because I consider consumer applications such as odo and Eclipse Che to be closer to that (Eclipse Che being an IDE), these do more than just building the project, with the devfile you can spec it to configure Che how to open up and use the workspace, you can also configure the devfile to define how Che or odo runs the commands you need for your workspace, even set init containers if needed. Build tools are more like maven that focuses more on what to specific project needs to build such as setting the stack version and defining the dependencies of the project. You can use a devfile to use the build tools for the stack being used for the project, e.g. defining the maven commands to run in the developer container. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I feel like the best here is to link "Certain tools" to a page describing what are the tools, what they do and what do they need the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
@abitrolly We have these tools listed under a documentation page, https://devfile.io/docs/2.3.0/developing-with-devfiles, are you asking that we link it here to provide more clarification on what is a devfile and its consumer tools? We also need to be careful how specific we are being with this as devfile is an open standard for any tool that are used in this circumstance, so just stating that devfile is only for these list of tools does not communicate this the right way. I think if we stated it can be used with these list of tools would be sufficient enough. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tools that support Sounds better? Also removes the need in the next sentence, |
||||||
to configure, build, and run an application from a development project. | ||||||
|
||||||
Using devfile, the tools or IDE can: | ||||||
|
||||||
- Take in the repository hosting your application source code. | ||||||
|
||||||
|
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line is too long to see the diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abitrolly Is this better? I doubt I can get it better, this block suggestion had a lot of changes suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-valdron the formatting is better, but the definition of "workspace" is vague. The descriptions fits the example on how to run VSCode session in Kubernetes cluster, which is not the case. It is not what is the difference between "devfile" and "devfile workspace" here..
Also it looks like it is impossible to use devfile without Kubernetes. Not sure if that's the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abitrolly
You are correct, one other case is podman with odo, other cases though are Kubernetes currently.
The devfile defines a project workspace that targets Kubernetes (or Podman), how commands are run for building, deploying, testing, etc. Depending on the devtool you could run your opened workspace in the cluster (Eclipse Che) or in an outside editor/IDE but connected (odo).
Perhaps this sounds better:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The definition of "workspace" is still vague. For me "workspace" is setup for local or remote IDE with colors. fonts, plugins, open panes and stuff. The devfile doesn't describe this.