feat: implement job architecture for image generation #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivictbor
reviewed
Sep 10, 2025
index.ts
Outdated
| this.totalDuration += (+new Date() - start) / 1000; | ||
|
|
||
| return resp.imageURLs[0] | ||
| setTimeout(async () => await this.generateImages(jobId, prompt, recordId, adminUser, headers), 100); |
There was a problem hiding this comment.
this.generateImages(jobId, prompt, recordId, adminUser, headers)
ivictbor
requested changes
Sep 10, 2025
custom/imageGenerator.vue
Outdated
| const jobId = resp.jobId; | ||
| let jobStatus = null; | ||
| let jobResponse = null; | ||
| while (jobStatus !== 'completed' && jobStatus !== 'failed') { |
There was a problem hiding this comment.
while jobStatus === 'inProgress'
index.ts
Outdated
|
|
||
| return resp.imageURLs[0] | ||
| setTimeout(async () => await this.generateImages(jobId, prompt, recordId, adminUser, headers), 100); | ||
| setTimeout(() => jobs.delete(jobId), 300_000); |
There was a problem hiding this comment.
add separate timeout which sets status to timed out after 5 minutes
ivictbor
requested changes
Sep 15, 2025
| method: 'POST', | ||
| body: { jobId }, | ||
| }); | ||
| if (jobResponse?.error) { |
There was a problem hiding this comment.
@yaroslav8765 just interesting, now please try to disable network (in network tab switch offline) during job, what will be and what will be best option?
- start generation
- wait 15 sec
- set offline mode
- wait 15 sec
- set online mode
will it work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.