Skip to content

Conversation

@rsdmike
Copy link
Member

@rsdmike rsdmike commented Jan 14, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 14, 2026 18:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors code to address the nestif linter issue by reducing code nesting complexity and updates the README with explicit linter configuration.

Changes:

  • Extracted nested password decryption logic into a separate decryptSecrets helper function to reduce nesting complexity in GetByID
  • Added explicit --config=./.golangci.yml flag to lint commands in README for clearer configuration

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
internal/usecase/devices/repo.go Refactored GetByID to extract nested password decryption logic into new decryptSecrets helper function, added entity import
README.md Updated golangci-lint commands to explicitly specify config file path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.67%. Comparing base (7e847c0) to head (414bcea).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/usecase/devices/repo.go 52.94% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #760   +/-   ##
=======================================
  Coverage   39.66%   39.67%           
=======================================
  Files         112      112           
  Lines       10652    10657    +5     
=======================================
+ Hits         4225     4228    +3     
- Misses       6046     6047    +1     
- Partials      381      382    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rsdmike rsdmike force-pushed the ciFix2 branch 3 times, most recently from c1c9578 to eac3a1d Compare January 14, 2026 19:58
@madhavilosetty-intel madhavilosetty-intel merged commit a95e245 into main Jan 14, 2026
19 checks passed
@madhavilosetty-intel madhavilosetty-intel deleted the ciFix2 branch January 14, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants