Skip to content

Conversation

@nbmaiti
Copy link

@nbmaiti nbmaiti commented Dec 12, 2025

-> devcontainer can use proxies

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )

@nbmaiti nbmaiti force-pushed the dev_container_proxy branch from f1b20f5 to d61d258 Compare December 12, 2025 12:43
@nbmaiti nbmaiti requested a review from rsdmike December 12, 2025 12:46
@rsdmike
Copy link
Member

rsdmike commented Dec 12, 2025

When opening in devcontainer im getting
image
"environment variable ignored: invalid URL" x2

can you update this to not have any errors?

Copy link
Member

@rsdmike rsdmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

    -> devcontainer can use proxies
    -> add cypress dependencies in devcontainer

Signed-off-by: Nabendu Maiti <[email protected]>
@nbmaiti nbmaiti force-pushed the dev_container_proxy branch 3 times, most recently from 1045ff5 to 07647d9 Compare December 14, 2025 01:31
@nbmaiti nbmaiti requested a review from rsdmike December 15, 2025 06:01
Copy link
Member

@rsdmike rsdmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what happens currently in main:

Image

in this branch i get:

Image

@nbmaiti nbmaiti force-pushed the dev_container_proxy branch from 07647d9 to 7148431 Compare December 16, 2025 03:41
@nbmaiti nbmaiti requested a review from rsdmike December 16, 2025 05:48
@nbmaiti nbmaiti force-pushed the dev_container_proxy branch 2 times, most recently from 12db66f to 45aafec Compare January 12, 2026 16:46
    - Add proxy handling for apt in different enviroments
    - fix non proxy env invalid error

Signed-off-by: Nabendu Maiti <[email protected]>
@nbmaiti nbmaiti force-pushed the dev_container_proxy branch from 45aafec to f60ed68 Compare January 12, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants