You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(wda): reject missing and invalid element bounds - #168
Reject missing or invalid WDA bounds so stale elements retry lookup instead of reporting a tap at (0, 0).
Validated with regression tests, the WDA race suite and iOS picker/negative checks; full checks remain blocked by existing lint/cancellation failures and a browser startup timeout.
Thanks @s4lmon, this is a real bug and a clean fix.
A /rect failure on a stale element was being swallowed, the bounds stayed at zero, and the tap landed at the screen origin and reported success. Turning that into an error is exactly right: findElementWithContext already treats an error as a retry and re-reads page source until the step timeout, and your test proves both the recovered and the disappeared case.
The zero-size rejection is a small behaviour change worth noting for anyone reading later: an element WDA reports with zero width or height is now "not found" rather than found, so assertVisible on it fails after its timeout and assertNotVisible passes. That is the sensible reading.
Built, vetted and ran the wda package tests locally, all green. The CI failures on this branch are pre-existing on main and unrelated to this change. Merging, this will go out in 1.1.28.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject missing or invalid WDA bounds so stale elements retry lookup instead of reporting a tap at
(0, 0).Validated with regression tests, the WDA race suite and iOS picker/negative checks; full checks remain blocked by existing lint/cancellation failures and a browser startup timeout.