Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Thanks @pr4bh4sh, nice work. I approved the workflow run and it's all green:
I also ran the CDP package locally with One request before merging: since the shard package lists are static, could you add a step that fails CI when a package isn't covered by any shard? Otherwise a package added later would silently never be tested. Something like: go list ./... | sort > all.txt
printf '%s\n' <all shard package lists> | tr ' ' '\n' | sort -u > sharded.txt
diff -u all.txt sharded.txtA small nit, optional: Happy to merge once the coverage check is in. |
The shard package lists in ci.yml are static, so a Go package added later would never be tested and CI would still be green. Add a step that diffs 'go list ./...' against the shard lists. The lists are read back out of this workflow file rather than repeated in the check, because a second copy would drift and then validate itself instead of the matrix - missing a typo or a package dropped from a shard. The check also catches a package assigned to two shards, since the sort is deliberately not 'sort -u'. Also rename CDP_PARALLEL to TEST_PARALLEL: 'go test -parallel' is a package-wide flag applied to every shard, so the old name implied it only affected CDP.
|
@omnarayan I have address the concerns. Tested the happy path and failure path here
job |
2 participants
Summary
cdp,s1,s2,s3).-parallel 4.Validation
go test ./... -run '^$'go test ./pkg/driver/browser/cdp -parallel 4 -timeout 25m -coverprofile=coverage-cdp.out -covermode=atomic— passed in 3m 06s with 80.9% coveragegofmtandgit diff --checkRelated tracking issue: pr4bh4sh#9