-
Notifications
You must be signed in to change notification settings - Fork 245
compiler: Add cire-minmem optoption #2792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2792 +/- ##
==========================================
+ Coverage 83.02% 83.03% +0.01%
==========================================
Files 248 248
Lines 50804 50874 +70
Branches 4479 4485 +6
==========================================
+ Hits 42180 42244 +64
- Misses 7857 7861 +4
- Partials 767 769 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
devito/passes/clusters/aliases.py
Outdated
| # Utilities | ||
|
|
||
|
|
||
| Size = namedtuple('Size', 'left right') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth renaming this Halo and use throughout ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot, since it's used for other things that are not halo strictly speaking, such as padding
However, what I did: I moved Size (and Offset) from types/basic.py into types/utils.py, so now Size is being imported by aliases.py directly from types/utils.py, instead of redefining it .
Pushed, if you want to take another look...
0683907 to
2abb329
Compare
3e10e33 to
fde18d7
Compare
fde18d7 to
22a288c
Compare
c02f3ad to
bdd41f1
Compare
8e9dd9c to
532d25c
Compare
No description provided.