Skip to content

Conversation

@FabioLuporini
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 96.74797% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.03%. Comparing base (59c357b) to head (532d25c).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
devito/passes/clusters/aliases.py 95.23% 2 Missing ⚠️
devito/passes/equations/linearity.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2792      +/-   ##
==========================================
+ Coverage   83.02%   83.03%   +0.01%     
==========================================
  Files         248      248              
  Lines       50804    50874      +70     
  Branches     4479     4485       +6     
==========================================
+ Hits        42180    42244      +64     
- Misses       7857     7861       +4     
- Partials      767      769       +2     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.51% <76.92%> (-0.03%) ⬇️
pytest-gpu-nvc-nvidiaX 69.05% <76.92%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# Utilities


Size = namedtuple('Size', 'left right')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth renaming this Halo and use throughout ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot, since it's used for other things that are not halo strictly speaking, such as padding

However, what I did: I moved Size (and Offset) from types/basic.py into types/utils.py, so now Size is being imported by aliases.py directly from types/utils.py, instead of redefining it .

Pushed, if you want to take another look...

@mloubout mloubout merged commit 3ce3395 into main Nov 21, 2025
39 checks passed
@mloubout mloubout deleted the tweak-cire-halo branch November 21, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants