Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include messages to standard error, this to make the log complete #57

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

Tasteful
Copy link
Contributor

@Tasteful Tasteful commented Dec 2, 2024

Fixes: #56

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2024

CLA assistant check
All committers have signed the CLA.

@kzu
Copy link
Member

kzu commented Feb 18, 2025

Wouldn't this make every report from the run result in output written to the error stream? Is that intentional?

@kzu kzu force-pushed the include-standard-error branch 2 times, most recently from 9381700 to b22b20b Compare February 18, 2025 08:58
@kzu kzu marked this pull request as draft February 18, 2025 09:05
@Tasteful
Copy link
Contributor Author

In the console you have two different output streams, the one that is named output and the one that usual is named as error and if we not forwarding both stream from the backend process we will miss information that can be good to include to find why test ar failing.

the output stream is also the one that you can use with the cmd > file.txt to write the output to a file or variable="$(cmd)" to set the output into a variable and in the later case it's important that error messages are written to the error, otherwise the info is set into the variable and it's very hard to recognize any errors.

So with this change we are collecting both the error and output stream and forward them to the reporter that will be the output stream. The reason I decided to pipe both of them into the output stream is that runner like devops agent thread data on the error stream as errors and in this case we dont want the execution terminate because the test in most case will work in the retry and then it's not an error any more.

@kzu kzu force-pushed the include-standard-error branch from b22b20b to 7d448b8 Compare February 25, 2025 03:07
@kzu kzu marked this pull request as ready for review February 25, 2025 03:07
@kzu
Copy link
Member

kzu commented Feb 25, 2025

Ah, gotcha. And it wouldn't change the current logic since we'd still get the exit code we were expecting.

👍

@kzu kzu merged commit 9cc768d into devlooped:main Feb 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include standard error in the result to make it easier to find errors.
4 participants