Skip to content

Conversation

@paul58914080
Copy link
Member

Checklist:

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My commits follow conventional commit message guidelines

@paul58914080 paul58914080 requested a review from a team as a code owner December 11, 2025 05:45
Copilot AI review requested due to automatic review settings December 11, 2025 05:45
@paul58914080 paul58914080 merged commit 48b9400 into main Dec 11, 2025
5 checks passed
@paul58914080 paul58914080 deleted the technical/jdk25-upgrade branch December 11, 2025 05:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request attempts to upgrade the project from Java 21 to Java 25. However, there are critical issues that prevent this upgrade from working. The PR updates Java version references in pom.xml, GitHub Actions workflows, documentation files, and dependabot configuration, as well as upgrading GitHub Actions versions.

Key Issues:

  • Java 25 does not exist yet - As of January 2025, Java 25 has not been released and is expected in September 2025
  • GitHub Actions versions upgraded to non-existent versions (checkout@v6 and setup-java@v5 don't exist)
  • Inconsistent java-version in workflow - One workflow file still references Java 21 in the setup step

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
example/pom.xml Updates Java version property from 21 to 25 (non-existent version)
example/.github/workflows/build_workflow.yml Updates workflow name and GitHub Actions versions; inconsistent java-version (still 21)
example/.github/dependabot.yml Reformats YAML indentation, adds commit message prefixes, and configures GitHub Actions dependency tracking
README.md Updates pre-requisite from JDK 21 to JDK 25
.github/workflows/ci-from-template.yaml Updates GitHub Actions versions and Java version to 25
.github/workflows/ci-for-example.yaml Updates GitHub Actions versions and Java version to 25
.github/dependabot.yml Adds commit message prefixes, assignees, labels, and GitHub Actions ecosystem tracking
.github/copilot-instructions.md Updates context from Java 21 to Java 25 and reformats documentation for better readability

uses: actions/setup-java@v5
with:
distribution: temurin
java-version: 21
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The java-version is still set to 21, but the step name was changed to "Set up JDK 25" and the pom.xml has been updated to Java 25. This inconsistency will cause the workflow to use Java 21 instead of Java 25, which defeats the purpose of this upgrade. Update the java-version to 25 to match the intended upgrade.

Suggested change
java-version: 21
java-version: 25

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants