Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link helm release #6432

Open
wants to merge 219 commits into
base: develop
Choose a base branch
from
Open

Link helm release #6432

wants to merge 219 commits into from

Conversation

iamayushm
Copy link
Contributor

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either move file or new code at new path /pkg/deployment/....

Base automatically changed from link-external-argocd to develop March 7, 2025 12:56
Copy link

gitguardian bot commented Mar 7, 2025

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
15200081 Triggered PGP Private Key e082b02 vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go View secret
15200082 Triggered PGP Private Key e082b02 vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go View secret
7214865 Triggered PGP Private Key f44a592 vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go View secret
15200083 Triggered PGP Private Key f44a592 vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go View secret
15200084 Triggered PGP Private Key e082b02 vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants