Skip to content

Conversation

@bogwar
Copy link
Collaborator

@bogwar bogwar commented Nov 5, 2025

No description provided.

@bogwar bogwar requested a review from Copilot November 5, 2025 11:02
@bogwar bogwar marked this pull request as draft November 5, 2025 11:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for ICRC-107 (Fee Management standard) and creates an overview page for Internet Computer standards. The changes include the complete specification for ICRC-107, which standardizes fee collection across ICRC-based ledgers, and a new overview document that categorizes and lists various ICRC standards.

Key changes:

  • Adds ICRC-107 specification for standardized fee management across ICRC ledgers
  • Creates a standards overview page to track standard lifecycle status
  • Introduces new block types and API methods for fee collector configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
ICRCs/overview.md Overview page listing ICRC standards organized by category with their approval status
ICRCs/ICRC-107/ICRC-107.md Complete specification for ICRC-107 Fee Management standard including transaction schemas, API methods, and legacy compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1,58 @@
his page provides an up-to-date overview of Internet Computer standards that are nearing completion, actively being developed, or have already been approved by the relevant working groups or the broader community.
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing 'T' at the beginning of the sentence. Should be 'This page' instead of 'his page'.

Suggested change
his page provides an up-to-date overview of Internet Computer standards that are nearing completion, actively being developed, or have already been approved by the relevant working groups or the broader community.
This page provides an up-to-date overview of Internet Computer standards that are nearing completion, actively being developed, or have already been approved by the relevant working groups or the broader community.

Copilot uses AI. Check for mistakes.
Comment on lines +43 to +58
| [ICRC-113](https://github.com/dfinity/wg-token-standards/pull/1) | ICP Network Registry | ![Draft] |
| ICRC-XX | Namespacing for `icp` URI scheme | ![Idea] |

### CAIP Compatibility Standards

| Standard | Title | Status |
|----------|---------------------------------------------|------------|
| [CAIP-2-compliant blockchain identifiers](https://github.com/dfinity/wg-token-standards/pull/2) | CAIP-2-compliant blockchain identifiers | ![Draft] |
| [CAIP-10-compliant account addresses](https://github.com/icvc/icp-namespace/pull/1) | CAIP-10-compliant account addresses | ![Draft] |

### Payment and Other Token-related Standards

| Standard | Title | Status |
|----------|---------------------------------------------|------------|
| [ICRC-22](https://github.com/dfinity/ICRC/pull/101/files) | URI Format for Payment Requests | ![Draft] |
| [ICRC-91](https://github.com/dfinity/ICRC/pull/96/files) | URI Scheme for Addressing Canister Content via HTTP | ![Draft] | No newline at end of file
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent capitalization in status badges. Lines 43, 44, 50, 51, 57, 58 use '![Draft]' and '![Idea]' with capital D and I, while other status badges like '![STANDARD]', '![APPROVED]', and '![DRAFT]' use all caps. This inconsistency suggests these may be undefined references in the markdown rendering system.

Suggested change
| [ICRC-113](https://github.com/dfinity/wg-token-standards/pull/1) | ICP Network Registry | ![Draft] |
| ICRC-XX | Namespacing for `icp` URI scheme | ![Idea] |
### CAIP Compatibility Standards
| Standard | Title | Status |
|----------|---------------------------------------------|------------|
| [CAIP-2-compliant blockchain identifiers](https://github.com/dfinity/wg-token-standards/pull/2) | CAIP-2-compliant blockchain identifiers | ![Draft] |
| [CAIP-10-compliant account addresses](https://github.com/icvc/icp-namespace/pull/1) | CAIP-10-compliant account addresses | ![Draft] |
### Payment and Other Token-related Standards
| Standard | Title | Status |
|----------|---------------------------------------------|------------|
| [ICRC-22](https://github.com/dfinity/ICRC/pull/101/files) | URI Format for Payment Requests | ![Draft] |
| [ICRC-91](https://github.com/dfinity/ICRC/pull/96/files) | URI Scheme for Addressing Canister Content via HTTP | ![Draft] |
| [ICRC-113](https://github.com/dfinity/wg-token-standards/pull/1) | ICP Network Registry | ![DRAFT] |
| ICRC-XX | Namespacing for `icp` URI scheme | ![IDEA] |
### CAIP Compatibility Standards
| Standard | Title | Status |
|----------|---------------------------------------------|------------|
| [CAIP-2-compliant blockchain identifiers](https://github.com/dfinity/wg-token-standards/pull/2) | CAIP-2-compliant blockchain identifiers | ![DRAFT] |
| [CAIP-10-compliant account addresses](https://github.com/icvc/icp-namespace/pull/1) | CAIP-10-compliant account addresses | ![DRAFT] |
### Payment and Other Token-related Standards
| Standard | Title | Status |
|----------|---------------------------------------------|------------|
| [ICRC-22](https://github.com/dfinity/ICRC/pull/101/files) | URI Format for Payment Requests | ![DRAFT] |
| [ICRC-91](https://github.com/dfinity/ICRC/pull/96/files) | URI Scheme for Addressing Canister Content via HTTP | ![DRAFT] |

Copilot uses AI. Check for mistakes.
- If legacy config designates a collector, credit that account.
- If no legacy collector is configured, burn the fee.

> **Important:** “No block with `btype = "107feecol"` is found is **not** the same as finding one with `tx.feecol = []`.
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error with duplicated 'is'. Should be either 'No block with btype = \"107feecol\" found is not' or 'Finding no block with btype = \"107feecol\" is not'.

Suggested change
> **Important:** No block with `btype = "107feecol"` is found is **not** the same as finding one with `tx.feecol = []`.
> **Important:** No block with `btype = "107feecol"` found is **not** the same as finding one with `tx.feecol = []`.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant