feat(ICRC-Index): FI-1759: stop indexing and report error in case of unknown block #6996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejdfinity
changed the title
maciejdfinity
dismissed
github-actions[bot]’s stale review
- $REASON_WHY_NO_NEED="No canister behavior changes."
- $REASON_WHY_NO_NEED="API same as before."
- $REASON_WHY_NO_NEED="No data change."
- $REASON_WHY_NO_NEED="No canister behavior changes."
mbjorkqvist
reviewed
Oct 14, 2025
gregorydemay
approved these changes
Oct 15, 2025
mbjorkqvist
approved these changes
Oct 16, 2025
Contributor
mbjorkqvist
left a comment
mbjorkqvist
left a comment
There was a problem hiding this comment.
Thanks @maciejdfinity, this is looking very good now! I just have a couple of minor questions/comments.
max-dfinity
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the index block validation by additionally checking for additional unrecognised fields. If an unknown/incorrect blocks is detected, we don't trap anymore but stop the indexing timer and log the error. The error can be accessed via the
/logshttp endpoint, e.g. for the ckBTC index: https://n5wcd-faaaa-aaaar-qaaea-cai.raw.icp0.io/logs.Since the cycles ledger and the latest iteration of the ICRC-3 standard allow for fees in
MintandBurnoperations, we additionally add these fields in the respective ICRC ledger operations - without those fields the index would not be able to sync the cycles ledger blocks. These fields are however never used or populated by the ICRC ledger -MintandBurntransactions with positive fees are always rejected.