feat(ICRC-Archive): DEFI-1906: add 107feecol to the list of supported block types #7795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejdfinity
changed the title
mbjorkqvist
approved these changes
Nov 25, 2025
Contributor
mbjorkqvist
left a comment
mbjorkqvist
left a comment
There was a problem hiding this comment.
I was a bit confused by the PR title - I don't think the archive (or the index) can claim to support ICRC-107 since they wouldn't support the icrc107_set_fee_collector endpoint (so they shouldn't return "ICRC-107" as a response to icrc1_supported_standards or icrc10_supported_standards), but returning "107feecol" in the icrc3_supported_block_types makes sense.
maciejdfinity
changed the title
Contributor
Author
|
@mbjorkqvist thanks for pointing this out! I adapted the title and the description of the PR. |
mraszyk
pushed a commit
that referenced
this pull request
Dec 1, 2025
… block types (#7795) The archive does not process the transactions, so the only thing needed for it to support `107feecol` block types is to add the fee collector block to `icrc_ledger_types::Transaction` and the `archive.did` file (done as part of #7411) and return `107feecol` in the list of supported block types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The archive does not process the transactions, so the only thing needed for it to support
107feecolblock types is to add the fee collector block toicrc_ledger_types::Transactionand thearchive.didfile (done as part of #7411) and return107feecolin the list of supported block types.