Combine access token and pull request checks in workflow #684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the changes from dfinity/snsdemo#380 (in snsdemo) to ic-js.
Motivation
EndBug/add-and-commitrequires that thecheckoutaction is called withref, when used on a pull request, so it knows which branch to commit to. For some reason this was not required on older versions (7) of EndBug/add-and-commit.In dfinity/snsdemo#368 I changed to an earlier version of
EndBug/add-and-committo avoid having to passrefto thecheckoutaction, depending on whether the run is for a PR, to avoid having to have 4 different checkout steps.I realized now that I only need to pass the token if I plan to make changes, so I can combine the checkout steps and still only have 2 while also using newer versions of
actions/checkoutandEndBug/add-and-commit.Changes
actions/checkout@v4andEndBug/[email protected].Tested
Was tested in the snsdemo repo but not separately tested in the ic-js repo.