Skip to content

Conversation

@dskloetd
Copy link
Contributor

This applies the changes from dfinity/snsdemo#380 (in snsdemo) to ic-js.

Motivation

EndBug/add-and-commit requires that the checkout action is called with ref, when used on a pull request, so it knows which branch to commit to. For some reason this was not required on older versions (7) of EndBug/add-and-commit.

In dfinity/snsdemo#368 I changed to an earlier version of EndBug/add-and-commit to avoid having to pass ref to the checkout action, depending on whether the run is for a PR, to avoid having to have 4 different checkout steps.
I realized now that I only need to pass the token if I plan to make changes, so I can combine the checkout steps and still only have 2 while also using newer versions of actions/checkout and EndBug/add-and-commit.

Changes

  1. Check whether commits can be added based on both the presence of the PAT token and the even being for a PR.
  2. Use actions/checkout@v4 and EndBug/[email protected].

Tested

Was tested in the snsdemo repo but not separately tested in the ic-js repo.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/ckbtc 7.91 KB (0%)
@dfinity/cketh 3.45 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.9 KB (0%)
@dfinity/ledger-icp 15.23 KB (0%)
@dfinity/nns 35.68 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.71 KB (0%)
@dfinity/utils 4.47 KB (0%)
@dfinity/ic-management 2.78 KB (0%)

@dskloetd dskloetd marked this pull request as ready for review July 23, 2024 09:47
@dskloetd dskloetd requested review from a team as code owners July 23, 2024 09:47
@dskloetd dskloetd enabled auto-merge (squash) July 23, 2024 09:48
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dskloetd dskloetd merged commit bdb93dc into main Jul 23, 2024
@dskloetd dskloetd deleted the kloet/endbug branch July 23, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants