chore: Prepare id.ai for SEO #3392
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds essential SEO assets and meta tags to improve search engine indexing for id.ai. The changes include OpenGraph and Twitter meta tags for better social media sharing, along with robots.txt and sitemap.xml files to guide search engine crawlers.
- Added comprehensive meta tags for SEO, OpenGraph, and Twitter sharing
- Created robots.txt file to control search engine crawling behavior
- Added sitemap.xml with main site URLs for search engine discovery
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/frontend/src/app.html | Added SEO meta tags, OpenGraph properties, and Twitter card metadata |
| src/frontend/static/robots.txt | Created robots.txt file allowing all crawlers with sitemap reference |
| src/frontend/static/sitemap.xml | Added XML sitemap with homepage and login page URLs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: Copilot <[email protected]>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Copilot <[email protected]>
lmuntaner
left a comment
lmuntaner
left a comment
There was a problem hiding this comment.
Why is the PR removing types and logos?
lmuntaner
left a comment
lmuntaner
left a comment
There was a problem hiding this comment.
Sorry, I didn't read the PR description again. I just did it.
How did you decide what logos to remove?
Approving to not block the changes as they are already an improvement.
peterpeterparker
left a comment
peterpeterparker
left a comment
There was a problem hiding this comment.
Dumb question: is the two lines “Experience Real Privacy” not being centered in the social image expected?
I'm so cartesian 😄
We fixed this. :) |
# Motivation I'm not entirely sure this is a strict requirement for a SPA, even if the pages are prerendered, since each page is behind a login screen and ultimately rendered with JavaScript. However, while reviewing a [PR](dfinity/internet-identity#3392 (comment)) in Internet Identity, it crossed my mind that it might be more accurate to use a canonical URL - and correspondingly an `og:url` - that reflects each subpage’s actual path rather than always pointing to the root. So, this PR introduces a similar change to what I just implemented for Juno ([PR](junobuild/juno#2035)). # Test I tested the change locally, but it definitely needs to be verified the next time you deploy to any environment. # Notes I'm really not certain this is necessary, so feel free to reject and close the PR if you don’t think it adds value. # Changes - Added a script to update the canonical and `og:url` after build - Chained the script in the post-process step before calculating the CSP --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
4 participants
Motivation
Google currently does not properly index id.ai. This PR adds the missing assets and meta tags to aid search engine crawlers.
Changes
Tests
No new tests needed (will test this on beta)