feat: improved --stable-compatible migration check
#4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreif
changed the title
--stable-compatible migration check
ggreif
added
feature
ggreif
reviewed
Apr 2, 2025
ggreif
reviewed
Apr 2, 2025
ggreif
reviewed
Apr 2, 2025
ggreif
reviewed
Apr 2, 2025
src/pipeline/pipeline.ml
Outdated
| @@ -288,7 +288,7 @@ let validate_stab_sig s : unit Diag.result = | |||
| | Single s1, Single s2 -> | |||
| Stability.match_stab_sig (Single s1) (Single s2) | |||
| | PrePost (pre1, post1), PrePost (pre2, post2) -> | |||
| let* () = Stability.match_stab_sig (Single pre1) (Single pre2) in | |||
| (* let* () = Stability.match_stab_sig (Single pre1) (Single pre2) in *) | |||
There was a problem hiding this comment.
This is just a sanity check on the produced signature, to ensure they parse and match reflexively. I 'll adjust the code a bit (maybe just dropping the required fields before checking the pre sigs (or something better).
ggreif
requested changes
Apr 2, 2025
|
@ggreif PTAL |
Co-authored-by: Gabor Greif <[email protected]>
Co-authored-by: Gabor Greif <[email protected]>
ggreif
force-pushed
the
claudio/improved-migration-check
branch
from
9f3e7d6 to
f9c8e35
Compare
|
@Mergifyio refresh |
✅ Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine the
*.moststable signature file format to distinguish stable variables that are strictly required by the migration function rather than propagated from the actor body (#4991).This enables the stable compatibility check to verify that a migration function will not fail due to missing required fields.
Required fields are declared
in, notstable, in the actor's pre-signature.Backwards compatible.