chore: Update Proposals types for potentially any IC commit #7082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabib
changed the title
yhabib
force-pushed
the
yhabib/proposals/latest
branch
from
09eab73 to
5b6bd84
Compare
yhabib
force-pushed
the
yhabib/proposals/latest
branch
from
5b6bd84 to
9acb1cf
Compare
2 tasks
yhabib
force-pushed
the
yhabib/proposals/latest
branch
from
9acb1cf to
0a94acd
Compare
# Motivation
We would like to render all the latest proposal types.
Even with no changes, just updating the reference is good practice.
# Changes
* Update the version of `IC_COMMIT_FOR_PROPOSALS` specified in
`config.json`.
* Updated the `proposals` candid files to the versions in that commit.
* Updated the Rust code derived from `.did` files in the proposals
payload rendering crate.
# Tests
- [ ] Please check the API updates for any breaking changes that affect
our code.
- [ ] Please check for new proposal types and add tests for them.
Breaking changes are:
* New mandatory fields
* Removing mandatory fields
* Renaming fields
* Changing the type of a field
* Adding new variants
Co-authored-by: gix-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Like in #7079, this PR updates proposals based on the main branch and not a release
Changes
update-aggregatorCI job now checks for any new IC commits.Tests
Todos