Skip to content

Conversation

@yhabib
Copy link
Contributor

@yhabib yhabib commented Jan 6, 2026

Motivation

Bumps ledger related dependencies to add support to the new Ledger Nano Gen5 device.

Changes

  • Bumped ledger dependencies to their latest version.

Tests

  • Tested locally with a new Gen 5 device.

Todos

  • Accessibility (a11y) – any impact?
  • Changelog – is it needed?

@yhabib yhabib changed the title bump ledger related deps chore(deps): bump Ledger libraries to support Nano Gen5 device Jan 6, 2026
@yhabib yhabib requested a review from Copilot January 7, 2026 08:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Ledger hardware wallet libraries to add support for the new Ledger Nano Gen5 device by bumping related dependencies to their latest versions.

Key Changes:

  • Updated @ledgerhq/hw-transport-webhid from ^6.27.8 to ^6.30.11
  • Updated @ledgerhq/hw-transport-node-hid-noevents from ^6.27.8 to ^6.30.16
  • Updated transitive dependencies including @ledgerhq/devices, @ledgerhq/errors, and @ledgerhq/hw-transport

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
frontend/package.json Bumped two main Ledger transport library versions to support Nano Gen5 device
frontend/package-lock.json Updated lockfile with new versions and integrity hashes for Ledger dependencies and their transitive dependencies
Files not reviewed (1)
  • frontend/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yhabib yhabib marked this pull request as ready for review January 9, 2026 10:07
@yhabib yhabib requested a review from a team as a code owner January 9, 2026 10:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • frontend/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

Speaking of, I wonder if @ledgerhq/hw-transport-node-hid-noevents is really useful. I started a draft #7349 few momths ago to remove it but, I think we never tested it.

@yhabib yhabib added this pull request to the merge queue Jan 9, 2026
@yhabib
Copy link
Contributor Author

yhabib commented Jan 9, 2026

LGTM, thx

Speaking of, I wonder if @ledgerhq/hw-transport-node-hid-noevents is really useful. I started a draft #7349 few momths ago to remove it but, I think we never tested it.

I did test it and we had an issue with a peer dep, https://dfinity.enterprise.slack.com/archives/C08DN0K8Q9G/p1758009025184629

@peterpeterparker
Copy link
Member

Ah thanks a ton, I had forgotten. Will had this reference to the draft!

Merged via the queue into main with commit aba8228 Jan 9, 2026
40 checks passed
@yhabib yhabib deleted the yhabib/bump-ledger-deps branch January 9, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants