Skip to content

feat: adding a note explaining userroles available #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dayures
Copy link
Contributor

@dayures dayures commented Mar 21, 2025

Copy link
Contributor

@jason-p-pickering jason-p-pickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dayures . I think we should go a bit further here. The important concept is that users

  1. Should not be able to give away their own roles due to the security issues you mention
  2. Only grant other users roles which themselves are a subset of their own role/roles.

While I think we can point out how to enable users giving away their own roles, I think we should provide a much clearer warning about what you generally do not want to do this.

@dayures
Copy link
Contributor Author

dayures commented Apr 8, 2025

@jason-p-pickering what do you think about adding this line at the beginning? "By default, to prevent security issues, users are not be able to give away their own roles. Users should only be able to grant other users roles that are a subset of their own."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants