fix: potential infinite loop on DialogicResourceUtil.gd #2421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My game was strangely freezing when trying to trigger a timeline. I looked into the codebase and I found out this while loop on DialogicResourceUtil caused the issue.
If file_path is
user://laura olsdal.dch
and directory is{ ..., "laura_olsdal": "res://assets/characters/laura_olsdal/laura_olsdal.dch", ... }
the code enters an infinite loop. So I just made a little check to break the loop ifsuggested_name
stops changing.