Upgrade build system for Visual Studio 2022 and Windows 11 compatibility#8
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Upgrade build system for Visual Studio 2022 and Windows 11 compatibility#8devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Update README to require Python 3.7+ and Visual Studio 2017 or later - Replace deprecated _winreg imports with winreg using try/except for backward compatibility - Update MSVC version check to support Visual Studio 2015+ (MSVC 14.x and 19.x) - Modernize Windows SDK targeting to try Windows 10 SDK first, fallback to 7.1A - Fix Python 2.7 syntax: iteritems() → items(), print statements → print() functions - Update error messages to reflect modern toolchain support Co-Authored-By: pranav@techesoterica.com <pranav.lal@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade build system for Visual Studio 2022 and Windows 11 compatibility
Summary
This PR modernizes the dictationBridge-core build system to support Visual Studio 2022 and Windows 11 while maintaining backward compatibility. The changes focus on three main areas:
_winreg→winreg,iteritems()→items(), print statements → print functions) with backward-compatible implementationsThe C++ code itself uses standard Windows APIs and should be compatible with Windows 11 without changes. The MinHook dependency already supports Visual Studio 2015+ so it will work with newer versions.
Review & Testing Checklist for Human
Recommended test plan: Try building the project on Windows 11 with Visual Studio 2022, then test with an older VS version to verify backward compatibility.
Diagram
%%{ init : { "theme" : "default" }}%% graph TD README["README.md<br/>Build requirements"]:::minor-edit SConstruct["SConstruct<br/>Main build script"]:::minor-edit archBuild["archBuild_SConscript<br/>MSVC version check"]:::major-edit windowsSdk["site_scons/site_tools/<br/>windowsSdk.py<br/>SDK detection"]:::major-edit jawsCommand["commands/commands/<br/>jawsDragonCommand.py<br/>Print syntax fix"]:::minor-edit SConstruct -->|imports| windowsSdk archBuild -->|uses| windowsSdk archBuild -->|version check| SConstruct subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#F5F5F5Notes