-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: 修复 RN 生命周期执行顺序 #1890
Open
wangshunnn
wants to merge
5
commits into
didi:master
Choose a base branch
from
wangshunnn:fix-rn-page-hook
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix: 修复 RN 生命周期执行顺序 #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyuki
reviewed
Mar 10, 2025
@@ -384,7 +400,9 @@ const pageStatusMap = global.__mpxPageStatusMap = reactive({}) | |||
|
|||
function usePageStatus (navigation, pageId) { | |||
navigation.pageId = pageId | |||
set(pageStatusMap, pageId, '') | |||
if (!hasOwn(pageStatusMap, pageId)) { | |||
set(pageStatusMap, pageId, '') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
确认一下为何page首次会渲染两次
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
定位到是 useHeaderHeight()
hook 运行结果变化导致的,内部是个 useContext
,第一次运行结果是 0,第二次正常值比如 101
import { useHeaderHeight } from '@react-navigation/elements'; |
const { PortalHost, useSafeAreaInsets, GestureHandlerRootView, useHeaderHeight } = global.__navigationHelper |
height: ReactNative.Dimensions.get('screen').height - useHeaderHeight() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
onLaunch
调整至页面created
之前onLoad
调整至组件ready
之前onShow
onHide
未执行 bug